]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: of: Use device_{add,remove}_of_node() to attach of_node to existing device
authorHerve Codina <herve.codina@bootlin.com>
Mon, 24 Feb 2025 14:13:52 +0000 (15:13 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 28 Feb 2025 21:13:07 +0000 (15:13 -0600)
commite2267841fe26d45d3c95958ddb71905a4cd4ac92
tree5cebd3c08368b276b5dc1c54483a65d7341d9432
parent3b62449da444502d8b87bf090d8ec4a57d47eda5
PCI: of: Use device_{add,remove}_of_node() to attach of_node to existing device

The commit 407d1a51921e ("PCI: Create device tree node for bridge")
creates of_node for PCI devices. The newly created of_node is attached
to an existing device. This is done setting directly pdev->dev.of_node
in the code.

Even if pdev->dev.of_node cannot be previously set, this doesn't handle
the fwnode field of the struct device. Indeed, this field needs to be
set if it hasn't already been set.

device_{add,remove}_of_node() have been introduced to handle this case.

Use them instead of the direct setting.

Link: https://lore.kernel.org/r/20250224141356.36325-3-herve.codina@bootlin.com
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
drivers/pci/of.c