]> www.infradead.org Git - users/dwmw2/linux.git/commit
phy: starfive: jh7110-usb: Fix link configuration to controller
authorJan Kiszka <jan.kiszka@siemens.com>
Tue, 15 Oct 2024 07:04:44 +0000 (15:04 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 17 Oct 2024 14:49:44 +0000 (20:19 +0530)
commite10c52e7e064038d9bd67b20bf4ce92077d7d84e
treeca6af473b2e1e3d44a168cdcd1fbe10b009f492e
parent031b46b4729b1a6ff8484a1e29cdb41b710ed740
phy: starfive: jh7110-usb: Fix link configuration to controller

In order to connect the USB 2.0 PHY to its controller, we also need to
set "u0_pdrstn_split_sw_usbpipe_plugen" [1]. Some downstream U-Boot
versions did that, but upstream firmware does not, and the kernel must
not rely on such behavior anyway. Failing to set this left the USB
gadget port invisible to connected hosts behind.

Link: https://doc-en.rvspace.org/JH7110/TRM/JH7110_TRM/sys_syscon.html#sys_syscon__section_b3l_fqs_wsb
Fixes: 16d3a71c20cf ("phy: starfive: Add JH7110 USB 2.0 PHY driver")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20241015070444.20972-2-minda.chen@starfivetech.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/starfive/phy-jh7110-usb.c