]> www.infradead.org Git - users/dwmw2/linux.git/commit
scsi: libsas: fix memory leak in sas_smp_get_phy_events()
authorJason Yan <yanaijie@huawei.com>
Thu, 4 Jan 2018 13:04:31 +0000 (21:04 +0800)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:29 +0000 (21:36 -0400)
commite0ef494d21a96b888cc8f878906a0c04238bf15d
tree3c11fbc9da7d5b8be887086a13486d7e6e4314d8
parentf5a04746cec0adc782a419e9912e6a4ec4b4fe1e
scsi: libsas: fix memory leak in sas_smp_get_phy_events()

[ Upstream commit 4a491b1ab11ca0556d2fda1ff1301e862a2d44c4 ]

We've got a memory leak with the following producer:

while true;
do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null;
done

The buffer req is allocated and not freed after we return. Fix it.

Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Signed-off-by: Jason Yan <yanaijie@huawei.com>
CC: John Garry <john.garry@huawei.com>
CC: chenqilin <chenqilin2@huawei.com>
CC: chenxiang <chenxiang66@hisilicon.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/scsi/libsas/sas_expander.c