]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: iwlwifi: limit printed string from FW file
authorJohannes Berg <johannes.berg@intel.com>
Sun, 9 Feb 2025 12:34:51 +0000 (14:34 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 11 Feb 2025 11:41:46 +0000 (12:41 +0100)
commite0dc2c1bef722cbf16ae557690861e5f91208129
tree47cc977b4e9d9dc63ddbdb3221aa6b10d375b7d6
parenta03e2082e678ea10d0d8bdf3ed933eb05a8ddbb0
wifi: iwlwifi: limit printed string from FW file

There's no guarantee here that the file is always with a
NUL-termination, so reading the string may read beyond the
end of the TLV. If that's the last TLV in the file, it can
perhaps even read beyond the end of the file buffer.

Fix that by limiting the print format to the size of the
buffer we have.

Fixes: aee1b6385e29 ("iwlwifi: support fseq tlv and print fseq version")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250209143303.cb5f9d0c2f5d.Idec695d53c6c2234aade306f7647b576c7e3d928@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-drv.c