]> www.infradead.org Git - users/jedix/linux-maple.git/commit
crypto: iaa - Fix potential use after free bug
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 24 Jul 2024 16:09:43 +0000 (11:09 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 2 Aug 2024 13:11:20 +0000 (21:11 +0800)
commite0d3b845a1b10b7b5abdad7ecc69d45b2aab3209
tree87887a035aa57888e19c240a492ca115927e4e14
parent2fc990581c0988ad35b41a1b4eca840deb3297e2
crypto: iaa - Fix potential use after free bug

The free_device_compression_mode(iaa_device, device_mode) function frees
"device_mode" but it iss passed to iaa_compression_modes[i]->free() a few
lines later resulting in a use after free.

The good news is that, so far as I can tell, nothing implements the
->free() function and the use after free happens in dead code.  But, with
this fix, when something does implement it, we'll be ready.  :)

Fixes: b190447e0fa3 ("crypto: iaa - Add compression mode management along with fixed mode")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/intel/iaa/iaa_crypto_main.c