]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: atomisp: Drop atomisp_pipe_check() from atomisp_link_setup()
authorHans de Goede <hdegoede@redhat.com>
Wed, 10 Apr 2024 16:15:32 +0000 (17:15 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 26 Apr 2024 09:54:38 +0000 (10:54 +0100)
commite03a5d3e95f22d15d8dfd97b1d31ea6247931b48
tree1f348b2e3d5cb391295b3b2c2e9425b1f6e09743
parent1c3432df2339c6fcc4399ea2299ad565bdb506e4
media: atomisp: Drop atomisp_pipe_check() from atomisp_link_setup()

The media-controller core (__media_entity_setup_link()) already checks
that the pads of the link are not streaming before calling the setup_link()
pad-op so calling atomisp_pipe_check() is not necessary;

and taking isp->mutex inside the setup_link() pad-op leads to a possible
ABBA deadlock vs the media-device graph_mutex which in the case of
the setup_link() pad-op is taken before calling the op, while in other
scenarios the graph_mutex is taken after the isp->mutex.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_subdev.c