]> www.infradead.org Git - users/jedix/linux-maple.git/commit
usb: xhci: Don't change the status of stalled TDs on failed Stop EP
authorMichal Pecio <michal.pecio@gmail.com>
Tue, 11 Mar 2025 15:45:50 +0000 (17:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Mar 2025 16:58:43 +0000 (17:58 +0100)
commitdfc88357b6b6356dadea06b2c0bc8041f5e11720
tree26c7a4a3722517b31a0c5465249f44355b1a4364
parent0c74d232578b1a7071e0312312811cb75b26b202
usb: xhci: Don't change the status of stalled TDs on failed Stop EP

When the device stalls an endpoint, current TD is assigned -EPIPE
status and Reset Endpoint is queued. If a Stop Endpoint is pending
at the time, it will run before Reset Endpoint and fail due to the
stall. Its handler will change TD's status to -EPROTO before Reset
Endpoint handler runs and initiates giveback.

Check if the stall has already been handled and don't try to do it
again. Since xhci_handle_halted_endpoint() performs this check too,
not overwriting td->status is the only difference.

I haven't seen this case yet, but I have seen a related one where
the xHC has already executed Reset Endpoint, EP Context state is
now Stopped and EP_HALTED is set. If the xHC took a bit longer to
execute Reset Endpoint, said case would become this one.

Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20250311154551.4035726-3-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c