]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mm, hugetlb: fix huge_pte_alloc BUG_ON
authorMichal Hocko <mhocko@suse.com>
Tue, 2 Aug 2016 21:02:34 +0000 (14:02 -0700)
committerChuck Anderson <chuck.anderson@oracle.com>
Mon, 19 Sep 2016 21:44:31 +0000 (14:44 -0700)
commitdf6a779db3db5fa7e46d74c74eaa0889b21cc439
treed7a9adca2ef6a31d1186b1ade627a15fda157c45
parentdd5d896f225498f5445b25d5b13ec0e34e6feeef
mm, hugetlb: fix huge_pte_alloc BUG_ON

Zhong Jiang has reported a BUG_ON from huge_pte_alloc hitting when he
runs his database load with memory online and offline running in
parallel.  The reason is that huge_pmd_share might detect a shared pmd
which is currently migrated and so it has migration pte which is
!pte_huge.

There doesn't seem to be any easy way to prevent from the race and in
fact seeing the migration swap entry is not harmful.  Both callers of
huge_pte_alloc are prepared to handle them.  copy_hugetlb_page_range
will copy the swap entry and make it COW if needed.  hugetlb_fault will
back off and so the page fault is retries if the page is still under
migration and waits for its completion in hugetlb_fault.

That means that the BUG_ON is wrong and we should update it.  Let's
simply check that all present ptes are pte_huge instead.

Link: http://lkml.kernel.org/r/20160721074340.GA26398@dhcp22.suse.cz
Signed-off-by: Michal Hocko <mhocko@suse.com>
Reported-by: zhongjiang <zhongjiang@huawei.com>
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Orabug: 24691289
(cherry picked from commit 4e666314d286765a9e61818b488c7372326654ec)
Acked-by: Chuck Anderson <chuck.anderson@oracle.com>
mm/hugetlb.c