]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: venus: destroy hfi session after m2m_ctx release
authorSergey Senozhatsky <senozhatsky@chromium.org>
Tue, 24 Dec 2024 07:24:05 +0000 (16:24 +0900)
committerHans Verkuil <hverkuil@xs4all.nl>
Mon, 6 Jan 2025 13:45:29 +0000 (14:45 +0100)
commitdf4ff47448fe0d392b29868e8398e3b0e587514d
tree1bcc42927cebd4b6f50f2667b88589f001c33cee
parentab2fd4a0ca26f3b4a7764f51ed3326ab89ab3213
media: venus: destroy hfi session after m2m_ctx release

This partially reverts commit that made hfi_session_destroy()
the first step of vdec/venc close().  The reason being is a
regression report when, supposedly, encode/decoder is closed
with still active streaming (no ->stop_streaming() call before
close()) and pending pkts, so isr_thread cannot find instance
and fails to process those pending pkts.  This was the idea
behind the original patch - make it impossible to use instance
under destruction, because this is racy, but apparently there
are uses cases that depend on that unsafe pattern.  Return to
the old (unsafe) behaviour for the time being (until a better
fix is found).

Fixes: 45b1a1b348ec ("media: venus: sync with threaded IRQ during inst destruction")
Cc: stable@vger.kernel.org
Reported-by: Nathan Hebert <nhebert@google.com>
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Stanimir Varbanov <stanimir.k.varbanov@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/qcom/venus/core.c