]> www.infradead.org Git - users/jedix/linux-maple.git/commit
gtp: fix a potential NULL pointer dereference
authorCong Wang <cong.wang@bytedance.com>
Sun, 25 Aug 2024 19:16:38 +0000 (12:16 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 27 Aug 2024 21:19:40 +0000 (14:19 -0700)
commitdefd8b3c37b0f9cb3e0f60f47d3d78d459d57fda
treee2d53b01dfcd17753a79378e455105201f924803
parent2fecbf75c40aca51ae35accbaa6ea051bb2340c4
gtp: fix a potential NULL pointer dereference

When sockfd_lookup() fails, gtp_encap_enable_socket() returns a
NULL pointer, but its callers only check for error pointers thus miss
the NULL pointer case.

Fix it by returning an error pointer with the error code carried from
sockfd_lookup().

(I found this bug during code inspection.)

Fixes: 1e3a3abd8b28 ("gtp: make GTP sockets in gtp_newlink optional")
Cc: Andreas Schultz <aschultz@tpip.net>
Cc: Harald Welte <laforge@gnumonks.org>
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
Link: https://patch.msgid.link/20240825191638.146748-1-xiyou.wangcong@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/gtp.c