]> www.infradead.org Git - users/jedix/linux-maple.git/commit
vxlan: test dev->flags & IFF_UP before calling gro_cells_receive()
authorEric Dumazet <edumazet@google.com>
Sun, 10 Mar 2019 17:36:40 +0000 (10:36 -0700)
committerBrian Maly <brian.maly@oracle.com>
Wed, 22 May 2019 03:56:13 +0000 (23:56 -0400)
commitdecbb48d5c08e278828785ff62a52f6eb44af701
treea21203b931b0361dd68fee3e582b3af445a00fa9
parent39a6752b486c535a4e1b00cb6b9d3297a43a5dd7
vxlan: test dev->flags & IFF_UP before calling gro_cells_receive()

Same reasons than the ones explained in commit 4179cb5a4c92
("vxlan: test dev->flags & IFF_UP before calling netif_rx()")

netif_rx() or gro_cells_receive() must be called under a strict contract.

At device dismantle phase, core networking clears IFF_UP
and flush_all_backlogs() is called after rcu grace period
to make sure no incoming packet might be in a cpu backlog
and still referencing the device.

A similar protocol is used for gro_cells infrastructure, as
gro_cells_destroy() will be called only after a full rcu
grace period is observed after IFF_UP has been cleared.

Most drivers call netif_rx() from their interrupt handler,
and since the interrupts are disabled at device dismantle,
netif_rx() does not have to check dev->flags & IFF_UP

Virtual drivers do not have this guarantee, and must
therefore make the check themselves.

Otherwise we risk use-after-free and/or crashes.

Orabug: 29710939

Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 59cbf56fcd98ba2a715b6e97c4e43f773f956393)

Reviewed-by: Rama Nichanamatlu <rama.nichanamatlu@oracle.com>
Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Conflicts:
drivers/net/vxlan.c
It was applying the patch at vxlan_udp_encap_recv()
instead of vxlan_rcv().

Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/vxlan.c