]> www.infradead.org Git - users/willy/pagecache.git/commit
drm/atomic: Filter out redundant DPMS calls
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 19 Feb 2025 16:02:39 +0000 (18:02 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 10 Mar 2025 16:18:37 +0000 (18:18 +0200)
commitde93ddf88088f7624b589d0ff3af9effb87e8f3b
treee405b30726bf5508c87ce5cb2f91851595049206
parentcba3b86974a3388b12130654809e50cd19294849
drm/atomic: Filter out redundant DPMS calls

Video players (eg. mpv) do periodic XResetScreenSaver() calls to
keep the screen on while the video playing. The modesetting ddx
plumbs these straight through into the kernel as DPMS setproperty
ioctls, without any filtering whatsoever. When implemented via
atomic these end up as empty commits on the crtc (which will
nonetheless take one full frame), which leads to a dropped
frame every time XResetScreenSaver() is called.

Let's just filter out redundant DPMS property changes in the
kernel to avoid this issue.

v2: Explain the resulting commits a bit better (Sima)
    Document the behaviour in uapi docs (Sima)

Cc: stable@vger.kernel.org
Testcase: igt/kms_flip/flip-vs-dpms-on-nop
Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250219160239.17502-1-ville.syrjala@linux.intel.com
drivers/gpu/drm/drm_atomic_uapi.c
drivers/gpu/drm/drm_connector.c