]> www.infradead.org Git - users/willy/xarray.git/commit
usb: typec: ucsi: Never send a lone connector change ack
authorChristian A. Ehrhardt <lk@c--e.de>
Wed, 27 Mar 2024 22:45:53 +0000 (23:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Apr 2024 15:07:17 +0000 (17:07 +0200)
commitde52aca4d9d56c3b2f00b638d457075914b1a227
tree7db204d4b0a3cf9a6b5b1fb873895f11c508b245
parentf3031f9b39c1e96f71bb032b73496c973ae7a60b
usb: typec: ucsi: Never send a lone connector change ack

Some PPM implementation do not like UCSI_ACK_CONNECTOR_CHANGE
without UCSI_ACK_COMMAND_COMPLETE. Moreover, doing this is racy
as it requires sending two UCSI_ACK_CC_CI commands in a row and
the second one will be started with UCSI_CCI_ACK_COMPLETE already
set in CCI.

Bundle the UCSI_ACK_CONNECTOR_CHANGE with the UCSI_ACK_COMMAND_COMPLETE
for the UCSI_GET_CONNECTOR_STATUS command that is sent while
handling a connector change event.

Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240327224554.1772525-3-lk@c--e.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/ucsi/ucsi.c