]> www.infradead.org Git - users/hch/configfs.git/commit
ibmvnic: Inspect header requirements before using scrq direct
authorNick Child <nnac123@linux.ibm.com>
Tue, 1 Oct 2024 16:32:00 +0000 (11:32 -0500)
committerJakub Kicinski <kuba@kernel.org>
Fri, 4 Oct 2024 19:04:09 +0000 (12:04 -0700)
commitde390657b5d6f7deb9d1d36aaf45f02ba51ec9dc
tree698cfa76dfd1c428388f58f5f6b7e2e87a7eb90f
parent69ea1d4ac916cac21ad976dd9cdec69878abac81
ibmvnic: Inspect header requirements before using scrq direct

Previously, the TX header requirement for standard frames was ignored.
This requirement is a bitstring sent from the VIOS which maps to the
type of header information needed during TX. If no header information,
is needed then send subcrq direct can be used (which can be more
performant).

This bitstring was previously ignored for standard packets (AKA non LSO,
non CSO) due to the belief that the bitstring was over-cautionary. It
turns out that there are some configurations where the backing device
does need header information for transmission of standard packets. If
the information is not supplied then this causes continuous "Adapter
error" transport events. Therefore, this bitstring should be respected
and observed before considering the use of send subcrq direct.

Fixes: 74839f7a8268 ("ibmvnic: Introduce send sub-crq direct")
Signed-off-by: Nick Child <nnac123@linux.ibm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241001163200.1802522-2-nnac123@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/ibmvnic.c