]> www.infradead.org Git - users/hch/misc.git/commit
ipvs: Always clear ipvs_property flag in skb_scrub_packet()
authorPhilo Lu <lulie@linux.alibaba.com>
Sat, 22 Feb 2025 03:35:18 +0000 (11:35 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 25 Feb 2025 12:15:17 +0000 (13:15 +0100)
commitde2c211868b9424f9aa9b3432c4430825bafb41b
tree4b4e357010ea9ddd38d6b9ccd5ef3a34099cd598
parent29b036be1b0bfcfc958380d5931325997fddf08a
ipvs: Always clear ipvs_property flag in skb_scrub_packet()

We found an issue when using bpf_redirect with ipvs NAT mode after
commit ff70202b2d1a ("dev_forward_skb: do not scrub skb mark within
the same name space"). Particularly, we use bpf_redirect to return
the skb directly back to the netif it comes from, i.e., xnet is
false in skb_scrub_packet(), and then ipvs_property is preserved
and SNAT is skipped in the rx path.

ipvs_property has been already cleared when netns is changed in
commit 2b5ec1a5f973 ("netfilter/ipvs: clear ipvs_property flag when
SKB net namespace changed"). This patch just clears it in spite of
netns.

Fixes: 2b5ec1a5f973 ("netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed")
Signed-off-by: Philo Lu <lulie@linux.alibaba.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Link: https://patch.msgid.link/20250222033518.126087-1-lulie@linux.alibaba.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/core/skbuff.c