]> www.infradead.org Git - users/jedix/linux-maple.git/commit
gpio: bcm-kona: Fix GPIO lock/unlock for banks above bank 0
authorArtur Weber <aweber.kernel@gmail.com>
Thu, 6 Feb 2025 17:46:00 +0000 (18:46 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 11 Feb 2025 08:46:59 +0000 (09:46 +0100)
commitde1d0d160f64ee76df1d364d521b2faf465a091c
treea0ea4091a16a212301102cd5ccb5500477320441
parenta64dcfb451e254085a7daee5fe51bf22959d52d3
gpio: bcm-kona: Fix GPIO lock/unlock for banks above bank 0

The GPIO lock/unlock functions clear/write a bit to the relevant
register for each bank. However, due to an oversight the bit that
was being written was based on the total GPIO number, not the index
of the GPIO within the relevant bank, causing it to fail for any
GPIO above 32 (thus any GPIO for banks above bank 0).

Fix lock/unlock for these banks by using the correct bit.

Fixes: bdb93c03c550 ("gpio: bcm281xx: Centralize register locking")
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Markus Mayer <mmayer@broadcom.com>
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250206-kona-gpio-fixes-v2-1-409135eab780@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-bcm-kona.c