]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fbdev: omapfb: Fix an OF node leak in dss_of_port_get_parent_device()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Wed, 8 Jan 2025 01:15:37 +0000 (10:15 +0900)
committerHelge Deller <deller@gmx.de>
Wed, 8 Jan 2025 23:35:09 +0000 (00:35 +0100)
commitde124b61e179e690277116e6be512e4f422b5dd8
tree1164abadee73411ed275c39d80b941a76555b1a6
parent021e111ed08d135963fe3e13d8264b82b2a147dc
fbdev: omapfb: Fix an OF node leak in dss_of_port_get_parent_device()

dss_of_port_get_parent_device() leaks an OF node reference when i >= 2
and struct device_node *np is present. Since of_get_next_parent()
obtains a reference of the returned OF node, call of_node_put() before
returning NULL.

This was found by an experimental verifier that I am developing, and no
runtime test was able to be performed due to that lack of actual
devices.

Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/omap2/omapfb/dss/dss-of.c