]> www.infradead.org Git - users/jedix/linux-maple.git/commit
igc: Fix XSK queue NAPI ID mapping
authorJoe Damato <jdamato@fastly.com>
Wed, 5 Mar 2025 18:09:00 +0000 (18:09 +0000)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 2 Apr 2025 15:51:41 +0000 (08:51 -0700)
commitdddeeaa16ce9d163ccf3b681715512d338afa541
tree1d95d8d74cb21202991d393de40e7b7ee9b922c8
parentacc4d5ff0b61eb1715c498b6536c38c1feb7f3c1
igc: Fix XSK queue NAPI ID mapping

In commit b65969856d4f ("igc: Link queues to NAPI instances"), the XSK
queues were incorrectly unmapped from their NAPI instances. After
discussion on the mailing list and the introduction of a test to codify
the expected behavior, we can see that the unmapping causes the
check_xsk test to fail:

NETIF=enp86s0 ./tools/testing/selftests/drivers/net/queues.py

[...]
  # Check|     ksft_eq(q.get('xsk', None), {},
  # Check failed None != {} xsk attr on queue we configured
  not ok 4 queues.check_xsk

After this commit, the test passes:

  ok 4 queues.check_xsk

Note that the test itself is only in net-next, so I tested this change
by applying it to my local net-next tree, booting, and running the test.

Cc: stable@vger.kernel.org
Fixes: b65969856d4f ("igc: Link queues to NAPI instances")
Signed-off-by: Joe Damato <jdamato@fastly.com>
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Tested-by: Mor Bar-Gabay <morx.bar.gabay@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc.h
drivers/net/ethernet/intel/igc/igc_main.c
drivers/net/ethernet/intel/igc/igc_xdp.c