]> www.infradead.org Git - users/hch/misc.git/commit
drm/radeon: fix uninitialized size issue in radeon_vce_cs_parse()
authorNikita Zhandarovich <n.zhandarovich@fintech.ru>
Tue, 11 Mar 2025 11:14:59 +0000 (14:14 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 18 Mar 2025 20:24:44 +0000 (16:24 -0400)
commitdd8689b52a24807c2d5ce0a17cb26dc87f75235c
treeedfd4a083e7e7a5d5e2d8ade35741332400d7ab9
parent6cc30748e17ea2a64051ceaf83a8372484e597f1
drm/radeon: fix uninitialized size issue in radeon_vce_cs_parse()

On the off chance that command stream passed from userspace via
ioctl() call to radeon_vce_cs_parse() is weirdly crafted and
first command to execute is to encode (case 0x03000001), the function
in question will attempt to call radeon_vce_cs_reloc() with size
argument that has not been properly initialized. Specifically, 'size'
will point to 'tmp' variable before the latter had a chance to be
assigned any value.

Play it safe and init 'tmp' with 0, thus ensuring that
radeon_vce_cs_reloc() will catch an early error in cases like these.

Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.

Fixes: 2fc5703abda2 ("drm/radeon: check VCE relocation buffer range v3")
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 2d52de55f9ee7aaee0e09ac443f77855989c6b68)
Cc: stable@vger.kernel.org
drivers/gpu/drm/radeon/radeon_vce.c