]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/shmem-helper: Fix unsetting shmem vaddr while vmap refcount > 0
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Thu, 3 Apr 2025 14:26:33 +0000 (17:26 +0300)
committerDmitry Osipenko <dmitry.osipenko@collabora.com>
Fri, 4 Apr 2025 12:56:44 +0000 (15:56 +0300)
commitdd717762761807452ca25634652e180a80349cd8
tree3838b83a8de20613345cbeb220e0aaf8356db98b
parent446d38554dc43e8391441fb3413512ba87a88583
drm/shmem-helper: Fix unsetting shmem vaddr while vmap refcount > 0

We switched to use refcount_t for vmaps and missed to change the vunmap
code to properly unset the vmap pointer, which is now cleared while vmap's
refcount > 0. Clear the cached vmap pointer only when refcounting drops to
zero to fix the bug.

Fixes: e1fc39a92332 ("drm/shmem-helper: Use refcount_t for vmap_use_count")
Reported-by: Lucas De Marchi <lucas.demarchi@intel.com>
Closes: https://lore.kernel.org/dri-devel/20250403105053.788b0f6e@collabora.com/T/#m3dca6d81bedc8d6146a56b82694624fbc6fa4c96
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Tested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20250403142633.484660-1-dmitry.osipenko@collabora.com
drivers/gpu/drm/drm_gem_shmem_helper.c