]> www.infradead.org Git - users/dwmw2/linux.git/commit
idpf: fix kernel panic on unknown packet types
authorJoshua Hay <joshua.a.hay@intel.com>
Thu, 21 Mar 2024 00:09:25 +0000 (17:09 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 3 Apr 2024 20:07:28 +0000 (13:07 -0700)
commitdd19e827d63ac60debf117676d1126bff884bdb8
tree67a5fd7fbc1455f3ab9c650beaac8a1bf15b5fcf
parent8edfc7a40e3300fc6c5fa7a3228a24d5bcd86ba5
idpf: fix kernel panic on unknown packet types

In the very rare case where a packet type is unknown to the driver,
idpf_rx_process_skb_fields would return early without calling
eth_type_trans to set the skb protocol / the network layer handler.
This is especially problematic if tcpdump is running when such a
packet is received, i.e. it would cause a kernel panic.

Instead, call eth_type_trans for every single packet, even when
the packet type is unknown.

Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support")
Reported-by: Balazs Nemeth <bnemeth@redhat.com>
Signed-off-by: Joshua Hay <joshua.a.hay@intel.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Tested-by: Salvatore Daniele <sdaniele@redhat.com>
Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/idpf/idpf_txrx.c