]> www.infradead.org Git - users/dwmw2/qemu.git/commit
target/i386: pull cc_op update to callers of gen_jmp_rel{,_csize}
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 10 Apr 2024 10:29:52 +0000 (12:29 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 7 May 2024 06:51:43 +0000 (08:51 +0200)
commitdd17322be7c6aa07ba792d661f1920c717ad5c94
tree1bf545b9d72c896ee61b6320e558e28d64ae7b86
parentbbba9594e84f60707558cce9cd3e4d70b9bd0fec
target/i386: pull cc_op update to callers of gen_jmp_rel{,_csize}

gen_update_cc_op must be called before control flow splits.  Doing it
in gen_jmp_rel{,_csize} may hide bugs, instead assert that cc_op is
clean---even if that means a few more calls to gen_update_cc_op().

With this new invariant, setting cc_op to CC_OP_DYNAMIC is unnecessary
since the caller should have done it.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/tcg/translate.c