]> www.infradead.org Git - users/jedix/linux-maple.git/commit
m68k: coldfire: select PCI_IOMAP for PCI
authorArnd Bergmann <arnd@arndb.de>
Mon, 24 Mar 2025 06:53:47 +0000 (07:53 +0100)
committerArnd Bergmann <arnd@arndb.de>
Mon, 24 Mar 2025 14:41:07 +0000 (15:41 +0100)
commitdcce85484d3abe0fe0a930a154bdc076f1eb4ae0
tree6b211aa893500633c22f284127b81172d545ddee
parenteb6a0803c9dbd1307e26509a01e4ecf69db6b953
m68k: coldfire: select PCI_IOMAP for PCI

After I dropped CONFIG_GENERIC_IOMAP, some PCI drivers started failing
to link when CONFIG_MMU is disabled:

ERROR: modpost: "pci_iounmap" [drivers/video/fbdev/i740fb.ko] undefined!
ERROR: modpost: "pci_iounmap" [drivers/video/fbdev/vt8623fb.ko] undefined!
ERROR: modpost: "pci_iomap_wc" [drivers/video/fbdev/vt8623fb.ko] undefined!
ERROR: modpost: "pci_iomap" [drivers/video/fbdev/vt8623fb.ko] undefined!
ERROR: modpost: "pci_iounmap" [drivers/video/fbdev/s3fb.ko] undefined!
...

It turns out that there were two mistakes in my patch: on !MMU I forgot
to enable CONFIG_GENERIC_PCI_IOMAP, and for Coldfire with MMU enabled,
teh GENERIC_IOMAP was left in place but incorrectly configured.

Fixes: 9d48cc07d0d7 ("m68k/nommu: stop using GENERIC_IOMAP")
Reported-by: Greg Ungerer <gerg@linux-m68k.org>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/m68k/Kconfig