]> www.infradead.org Git - users/jedix/linux-maple.git/commit
pwm: loongson: Fix u32 overflow in waveform calculation
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Sat, 12 Apr 2025 12:21:24 +0000 (14:21 +0200)
committerUwe Kleine-König <ukleinek@kernel.org>
Wed, 16 Apr 2025 05:20:23 +0000 (07:20 +0200)
commitdcb882bd436e2124e37640671cfa773dfaed485c
treee8c3388573a89f9551b3d33ebfd9f05d02ee3d34
parent29f1d5cac294dbc0e9ebb9d1fea4e2c1c1d2e5f4
pwm: loongson: Fix u32 overflow in waveform calculation

mul_u64_u64_div_u64() returns an u64 that might be bigger than U32_MAX.
To properly handle this case it must not be directly assigned to an u32
value.

Use a wider type for duty and period to make the idiom:

duty = mul_u64_u64_div_u64(...)
if (duty > U32_MAX)
duty = U32_MAX;

actually work as intended.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/44f3c764-8b65-49a9-b3ad-797e9fbb96f5@stanley.mountain
Fixes: 2b62c89448dd ("pwm: Add Loongson PWM controller support")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://lore.kernel.org/r/20250412122124.1636152-2-u.kleine-koenig@baylibre.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/pwm-loongson.c