]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cxl: Fix devm host device for CXL fwctl initialization
authorDave Jiang <dave.jiang@intel.com>
Fri, 18 Apr 2025 00:29:33 +0000 (17:29 -0700)
committerDave Jiang <dave.jiang@intel.com>
Fri, 18 Apr 2025 16:33:04 +0000 (09:33 -0700)
commitdc915672f9176799e48ac23a155f48742b15ec6c
tree90d812e20c7ba153f24b8515528bcd0a3df58f5f
parent36aace15d9bdcfe6f03e078915067e89719478f5
cxl: Fix devm host device for CXL fwctl initialization

Testing revealed the following error message for a CXL memdev that has
Feature support:
[   56.690430] cxl mem0: Resources present before probing

Attach the allocation of cxl_fwctl to the parent device of cxl_memdev.
devm_add_* calls for cxl_memdev should not happen before the memdev
probe function or outside the scope of the memdev driver.

cxl_test missed this bug because cxl_test always arranges for the
cxl_mem driver to be loaded before cxl_mock_mem runs. So the driver core
always finds the devres list idle in that case.

[DJ: Updated subject title and added commit log suggestion from djbw]

Fixes: 858ce2f56b52 ("cxl: Add FWCTL support to CXL")
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Link: https://lore.kernel.org/linux-cxl/6801aea053466_71fe2944c@dwillia2-xfh.jf.intel.com.notmuch/
Link: https://patch.msgid.link/20250418002933.406439-1-dave.jiang@intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/features.c
drivers/cxl/pci.c
include/cxl/features.h
tools/testing/cxl/test/mem.c