]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf sample: Make user_regs and intr_regs optional
authorIan Rogers <irogers@google.com>
Mon, 13 Jan 2025 19:43:45 +0000 (11:43 -0800)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 13 Feb 2025 04:06:11 +0000 (20:06 -0800)
commitdc6d2bc2d893a878e7b58578ff01b4738708deb4
treeb5524ff4429f1e88533f518753091462bc4bd8b4
parent08d9e883481b2c38326ed37314b1f6a1284c03d8
perf sample: Make user_regs and intr_regs optional

The struct dump_regs contains 512 bytes of cache_regs, meaning the two
values in perf_sample contribute 1088 bytes of its total 1384 bytes
size. Initializing this much memory has a cost reported by Tavian
Barnes <tavianator@tavianator.com> as about 2.5% when running `perf
script --itrace=i0`:
https://lore.kernel.org/lkml/d841b97b3ad2ca8bcab07e4293375fb7c32dfce7.1736618095.git.tavianator@tavianator.com/

Adrian Hunter <adrian.hunter@intel.com> replied that the zero
initialization was necessary and couldn't simply be removed.

This patch aims to strike a middle ground of still zeroing the
perf_sample, but removing 79% of its size by make user_regs and
intr_regs optional pointers to zalloc-ed memory. To support the
allocation accessors are created for user_regs and intr_regs. To
support correct cleanup perf_sample__init and perf_sample__exit
functions are created and added throughout the code base.

Signed-off-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250113194345.1537821-1-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
34 files changed:
tools/perf/arch/x86/tests/dwarf-unwind.c
tools/perf/arch/x86/util/unwind-libdw.c
tools/perf/builtin-record.c
tools/perf/builtin-script.c
tools/perf/builtin-top.c
tools/perf/builtin-trace.c
tools/perf/tests/code-reading.c
tools/perf/tests/dwarf-unwind.c
tools/perf/tests/mmap-basic.c
tools/perf/tests/openat-syscall-tp-fields.c
tools/perf/tests/parse-no-sample-id-all.c
tools/perf/tests/perf-record.c
tools/perf/tests/perf-time-to-tsc.c
tools/perf/tests/sample-parsing.c
tools/perf/tests/sw-clock.c
tools/perf/tests/switch-tracking.c
tools/perf/util/Build
tools/perf/util/arm-spe.c
tools/perf/util/arm64-frame-pointer-unwind-support.c
tools/perf/util/auxtrace.c
tools/perf/util/cs-etm.c
tools/perf/util/evsel.c
tools/perf/util/intel-bts.c
tools/perf/util/intel-pt.c
tools/perf/util/jitdump.c
tools/perf/util/machine.c
tools/perf/util/python.c
tools/perf/util/s390-cpumsf.c
tools/perf/util/sample.c [new file with mode: 0644]
tools/perf/util/sample.h
tools/perf/util/scripting-engines/trace-event-python.c
tools/perf/util/session.c
tools/perf/util/synthetic-events.c
tools/perf/util/unwind-libdw.c