]> www.infradead.org Git - users/jedix/linux-maple.git/commit
block: loop: avoiding too many pending per work I/O
authorMing Lei <ming.lei@canonical.com>
Tue, 5 May 2015 11:49:55 +0000 (19:49 +0800)
committerSantosh Shilimkar <santosh.shilimkar@oracle.com>
Wed, 29 Jul 2015 23:37:03 +0000 (16:37 -0700)
commitdc660fc6cf1e7328acb0dd1ba6a2aca7080838bf
tree1fde380de5aeb74ac7c2b0af45512afcfcc3fe78
parent06a20c9c32cc0dda4ed6eb6d14bf919ea9bcd8d3
block: loop: avoiding too many pending per work I/O

If there are too many pending per work I/O, too many
high priority work thread can be generated so that
system performance can be effected.

This patch limits the max_active parameter of workqueue as 16.

This patch fixes Fedora 22 live booting performance
regression when it is booted from squashfs over dm
based on loop, and looks the following reasons are
related with the problem:

- not like other filesyststems(such as ext4), squashfs
is a bit special, and I observed that increasing I/O jobs
to access file in squashfs only improve I/O performance a
little, but it can make big difference for ext4

- nested loop: both squashfs.img and ext3fs.img are mounted
as loop block, and ext3fs.img is inside the squashfs

- during booting, lots of tasks may run concurrently

Fixes: b5dd2f6047ca108001328aac0e8588edd15f1778
Cc: stable@vger.kernel.org (v4.0)
Cc: Justin M. Forbes <jforbes@fedoraproject.org>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
drivers/block/loop.c