]> www.infradead.org Git - users/jedix/linux-maple.git/commit
amd-xgbe: fix the false linkup in xgbe_phy_status
authorRaju Rangoju <Raju.Rangoju@amd.com>
Thu, 25 May 2023 18:26:12 +0000 (23:56 +0530)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 May 2023 09:42:06 +0000 (10:42 +0100)
commitdc362e20cd6ab7a93d1b09669730c406f0910c35
tree2dcfc8406fdbd63cc4534a655d5e8199bf9f5158
parent8a0d57df8938e9fd2e99d47a85b7f37d86f91097
amd-xgbe: fix the false linkup in xgbe_phy_status

In the event of a change in XGBE mode, the current auto-negotiation
needs to be reset and the AN cycle needs to be re-triggerred. However,
the current code ignores the return value of xgbe_set_mode(), leading to
false information as the link is declared without checking the status
register.

Fix this by propagating the mode switch status information to
xgbe_phy_status().

Fixes: e57f7a3feaef ("amd-xgbe: Prepare for working with more than one type of phy")
Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd.com>
Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amd/xgbe/xgbe-mdio.c