]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ext4: check for allocation block validity with block group locked
authorTheodore Ts'o <tytso@mit.edu>
Thu, 12 Jul 2018 23:08:05 +0000 (19:08 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Aug 2018 05:50:43 +0000 (07:50 +0200)
commitdc1b4b710fbef5f8f5a41efe35368e9dd07e71cb
tree9b4536f5cebb82ea87ba77ff67623d9cdf8cc781
parentcdcbe750acd6cd1e083189c2a50810eeb59f057a
ext4: check for allocation block validity with block group locked

commit 8d5a803c6a6ce4ec258e31f76059ea5153ba46ef upstream.

With commit 044e6e3d74a3: "ext4: don't update checksum of new
initialized bitmaps" the buffer valid bit will get set without
actually setting up the checksum for the allocation bitmap, since the
checksum will get calculated once we actually allocate an inode or
block.

If we are doing this, then we need to (re-)check the verified bit
after we take the block group lock.  Otherwise, we could race with
another process reading and verifying the bitmap, which would then
complain about the checksum being invalid.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1780137

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/balloc.c
fs/ext4/ialloc.c