]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iio: accel: bma400: Fix uninitialized variable field_value in tap event handling.
authorMikhail Lobanov <m.lobanov@rosalinux.ru>
Tue, 10 Sep 2024 08:36:20 +0000 (04:36 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 30 Sep 2024 08:20:53 +0000 (09:20 +0100)
commitdb9795a43dc944f048a37b65e06707f60f713e34
treef4e96bc8c35666727ae3a1c59e2c269e5e3cb1af
parent9852d85ec9d492ebef56dc5f229416c925758edc
iio: accel: bma400: Fix uninitialized variable field_value in tap event handling.

In the current implementation, the local variable field_value is used
without prior initialization, which may lead to reading uninitialized
memory. Specifically, in the macro set_mask_bits, the initial
(potentially uninitialized) value of the buffer is copied into old__,
and a mask is applied to calculate new__. A similar issue was resolved in
commit 6ee2a7058fea ("iio: accel: bma400: Fix smatch warning based on use
of unintialized value.").

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 961db2da159d ("iio: accel: bma400: Add support for single and double tap events")
Signed-off-by: Mikhail Lobanov <m.lobanov@rosalinux.ru>
Link: https://patch.msgid.link/20240910083624.27224-1-m.lobanov@rosalinux.ru
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/bma400_core.c