]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type
authorDamien Le Moal <dlemoal@kernel.org>
Fri, 18 Apr 2025 06:40:14 +0000 (15:40 +0900)
committerDamien Le Moal <dlemoal@kernel.org>
Tue, 22 Apr 2025 07:05:14 +0000 (16:05 +0900)
commitdb91586b1e8f36122a9e5b8fbced11741488dd22
treefb178ab08b201e73c42acb5e2f124266df8e462f
parent399eab7f92fb73ffe621294a2d6bec8fc9f3b36b
ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type

The function ata_mselect_control_ata_feature() has a return type defined
as unsigned int but this function may return negative error codes, which
are correctly propagated up the call chain as integers.

Fix ata_mselect_control_ata_feature() to have the correct int return
type.

While at it, also fix a typo in this function description comment.

Fixes: df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Igor Pylypiv <ipylypiv@google.com>
drivers/ata/libata-scsi.c