]> www.infradead.org Git - users/dwmw2/linux.git/commit
x86/vdso: Fix vDSO syscall fallback asm constraint regression
authorAndy Lutomirski <luto@kernel.org>
Wed, 3 Oct 2018 23:23:49 +0000 (16:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Oct 2018 07:33:13 +0000 (09:33 +0200)
commitdb68b064bb738cfc9648e048f40d317f77d170ca
tree288ecc87c916b62f68697a72e39fe8afc24b0d73
parent54f54a2b7fb3f6e8500b087d2694ef694bf95cd2
x86/vdso: Fix vDSO syscall fallback asm constraint regression

commit 02e425668f5c9deb42787d10001a3b605993ad15 upstream.

When I added the missing memory outputs, I failed to update the
index of the first argument (ebx) on 32-bit builds, which broke the
fallbacks.  Somehow I must have screwed up my testing or gotten
lucky.

Add another test to cover gettimeofday() as well.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Fixes: 715bd9d12f84 ("x86/vdso: Fix asm constraints on vDSO syscall fallbacks")
Link: http://lkml.kernel.org/r/21bd45ab04b6d838278fa5bebfa9163eceffa13c.1538608971.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/entry/vdso/vclock_gettime.c
tools/testing/selftests/x86/test_vdso.c