]> www.infradead.org Git - users/jedix/linux-maple.git/commit
firmware: qcom: uefisecapp: Fix deadlock in qcuefi_acquire()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 29 Aug 2024 19:23:04 +0000 (22:23 +0300)
committerBjorn Andersson <andersson@kernel.org>
Sat, 31 Aug 2024 03:17:50 +0000 (22:17 -0500)
commitdb213b0cfe3268d8b1d382b3bcc999c687a2567f
tree2d0ccbd746cd4f01d188fe40f303ecf2e25df81e
parentc158ceb826068a8bbe3c9e78df420f47ba53c8a8
firmware: qcom: uefisecapp: Fix deadlock in qcuefi_acquire()

If the __qcuefi pointer is not set, then in the original code, we would
hold onto the lock.  That means that if we tried to set it later, then
it would cause a deadlock.  Drop the lock on the error path.  That's
what all the callers are expecting.

Fixes: 759e7a2b62eb ("firmware: Add support for Qualcomm UEFI Secure Application")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/19829bc4-1b6f-47f7-847a-e90c25749e40@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/firmware/qcom/qcom_qseecom_uefisecapp.c