]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: ath12k: fix firmware crash due to invalid peer nss
authorAjith C <quic_ajithc@quicinc.com>
Thu, 13 Jun 2024 05:35:28 +0000 (11:05 +0530)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 19 Jun 2024 14:18:57 +0000 (17:18 +0300)
commitdb163a463bb93cd3e37e1e7b10b9726fb6f95857
treee8cb5eaf4f14ea84252e1b396e11691b9fd2786d
parent3005c63a3673eaf3202b2e0c951e5092539bf758
wifi: ath12k: fix firmware crash due to invalid peer nss

Currently, if the access point receives an association
request containing an Extended HE Capabilities Information
Element with an invalid MCS-NSS, it triggers a firmware
crash.

This issue arises when EHT-PHY capabilities shows support
for a bandwidth and MCS-NSS set for that particular
bandwidth is filled by zeros and due to this, driver obtains
peer_nss as 0 and sending this value to firmware causes
crash.

Address this issue by implementing a validation step for
the peer_nss value before passing it to the firmware. If
the value is greater than zero, proceed with forwarding
it to the firmware. However, if the value is invalid,
reject the association request to prevent potential
firmware crashes.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Signed-off-by: Ajith C <quic_ajithc@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20240613053528.2541645-1-quic_ajithc@quicinc.com
drivers/net/wireless/ath/ath12k/mac.c