]> www.infradead.org Git - users/hch/configfs.git/commit
net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input()
authorEric Dumazet <edumazet@google.com>
Fri, 31 May 2024 13:26:33 +0000 (13:26 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 4 Jun 2024 01:50:08 +0000 (18:50 -0700)
commitdb0090c6eb12c31246438b7fe2a8f1b833e7a653
treed7ac778dd6ff370c7b38190bfc2badc6a929bce1
parent2fe40483ec257de2a0d819ef88e3e76c7e261319
net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input()

As explained in commit 1378817486d6 ("tipc: block BH
before using dst_cache"), net/core/dst_cache.c
helpers need to be called with BH disabled.

Disabling preemption in rpl_output() is not good enough,
because rpl_output() is called from process context,
lwtunnel_output() only uses rcu_read_lock().

We might be interrupted by a softirq, re-enter rpl_output()
and corrupt dst_cache data structures.

Fix the race by using local_bh_disable() instead of
preempt_disable().

Apply a similar change in rpl_input().

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Alexander Aring <aahringo@redhat.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/20240531132636.2637995-3-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/rpl_iptunnel.c