]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ALSA: usx2y: Use snd_card_free_when_closed() at disconnection
authorTakashi Iwai <tiwai@suse.de>
Wed, 13 Nov 2024 11:10:35 +0000 (12:10 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 13 Nov 2024 12:33:46 +0000 (13:33 +0100)
commitdafb28f02be407e07a6f679e922a626592b481b0
treeada9fdf3a615d0de844ae1bbdee970b13bf3c289
parentf69c2861b05e29c69abed6aafe0cefd224d9d4db
ALSA: usx2y: Use snd_card_free_when_closed() at disconnection

The USB disconnect callback is supposed to be short and not too-long
waiting.  OTOH, the current code uses snd_card_free() at
disconnection, but this waits for the close of all used fds, hence it
can take long.  It eventually blocks the upper layer USB ioctls, which
may trigger a soft lockup.

An easy workaround is to replace snd_card_free() with
snd_card_free_when_closed().  This variant returns immediately while
the release of resources is done asynchronously by the card device
release at the last close.

Fixes: 230cd5e24853 ("[ALSA] prevent oops & dead keyboard on usb unplugging while the device is be ing used")
Reported-by: syzbot+73582d08864d8268b6fd@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=73582d08864d8268b6fd
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20241113111042.15058-2-tiwai@suse.de
sound/usb/usx2y/usbusx2y.c