]> www.infradead.org Git - users/dwmw2/linux.git/commit
iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call
authorOleksandr Ocheretnyi <oocheret@cisco.com>
Fri, 13 Sep 2024 19:14:03 +0000 (12:14 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 4 Nov 2024 12:12:58 +0000 (13:12 +0100)
commitdaa814d784ac034c62ab3fb0ef83daeafef527e2
treed7560cf209bd05058abc684a4b462193647ecefb
parent4497ee914f10264894b08066cbee026604cd244f
iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call

Commit da23b6faa8bf ("watchdog: iTCO: Add support for Cannon Lake
PCH iTCO") does not mask NMI_NOW bit during TCO1_CNT register's
value comparison for update_no_reboot_bit() call causing following
failure:

   ...
   iTCO_vendor_support: vendor-support=0
   iTCO_wdt iTCO_wdt: unable to reset NO_REBOOT flag, device
                                    disabled by hardware/BIOS
   ...

and this can lead to unexpected NMIs later during regular
crashkernel's workflow because of watchdog probe call failures.

This change masks NMI_NOW bit for TCO1_CNT register values to
avoid unexpected NMI_NOW bit inversions.

Fixes: da23b6faa8bf ("watchdog: iTCO: Add support for Cannon Lake PCH iTCO")
Signed-off-by: Oleksandr Ocheretnyi <oocheret@cisco.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20240913191403.2560805-1-oocheret@cisco.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/iTCO_wdt.c