]> www.infradead.org Git - users/jedix/linux-maple.git/commit
firmware: qcom: uefisecapp: fix efivars registration race
authorJohan Hovold <johan+linaro@kernel.org>
Mon, 20 Jan 2025 15:10:00 +0000 (16:10 +0100)
committerBjorn Andersson <andersson@kernel.org>
Sat, 8 Feb 2025 17:38:03 +0000 (11:38 -0600)
commitda8d493a80993972c427002684d0742560f3be4a
treea8b8347c026f7ce82b51894578318df3dda0ea91
parent7f048b202333b967782a98aa21bb3354dc379bbf
firmware: qcom: uefisecapp: fix efivars registration race

Since the conversion to using the TZ allocator, the efivars service is
registered before the memory pool has been allocated, something which
can lead to a NULL-pointer dereference in case of a racing EFI variable
access.

Make sure that all resources have been set up before registering the
efivars.

Fixes: 6612103ec35a ("firmware: qcom: qseecom: convert to using the TZ allocator")
Cc: stable@vger.kernel.org # 6.11
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20250120151000.13870-1-johan+linaro@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/firmware/qcom/qcom_qseecom_uefisecapp.c