]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iommu: iommufd: fix WARNING in iommufd_device_unbind
authorSuraj Sonawane <surajsonawane0215@gmail.com>
Sat, 23 Nov 2024 19:59:00 +0000 (01:29 +0530)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 14 Jan 2025 17:50:05 +0000 (13:50 -0400)
commitd9df72c6acd683adf6dd23c061f3a414ec00b1f8
treef00d873a64e9d5182a6900f89788c860f203b792
parent11534b4de2a1bcc438ed90d031184c9c847e8560
iommu: iommufd: fix WARNING in iommufd_device_unbind

Fix an issue detected by syzbot:

WARNING in iommufd_device_unbind iommufd: Time out waiting for iommufd object to become free

Resolve a warning in iommufd_device_unbind caused by a timeout while
waiting for the shortterm_users reference count to reach zero. The
existing 10-second timeout is insufficient in some scenarios, resulting in
failures the above warning.

Increase the timeout in iommufd_object_dec_wait_shortterm from 10 seconds
to 60 seconds to allow sufficient time for the reference count to drop to
zero. This change prevents premature timeouts and reduces the likelihood
of warnings during iommufd_device_unbind.

Fixes: 6f9c4d8c468c ("iommufd: Do not UAF during iommufd_put_object()")
Link: https://patch.msgid.link/r/20241123195900.3176-1-surajsonawane0215@gmail.com
Reported-by: syzbot+c92878e123785b1fa2db@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=c92878e123785b1fa2db
Tested-by: syzbot+c92878e123785b1fa2db@syzkaller.appspotmail.com
Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/main.c