]> www.infradead.org Git - users/jedix/linux-maple.git/commit
USB: fix out-of-bounds in usb_set_configuration
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2017 13:07:17 +0000 (15:07 +0200)
committerTim Tianyang Chen <tianyang.chen@oracle.com>
Fri, 8 Dec 2017 17:28:53 +0000 (09:28 -0800)
commitd96302a3e1e36efcc8741f35bfd83c83bd2134a7
treecdb9fdf503f66c7d2bf4b292defb28c101a4b053
parentd49dcb423a8b22ad619ed33240c46b261ad4a9e5
USB: fix out-of-bounds in usb_set_configuration

Andrey Konovalov reported a possible out-of-bounds problem for a USB interface
association descriptor.  He writes:
It seems there's no proper size check of a USB_DT_INTERFACE_ASSOCIATION
descriptor. It's only checked that the size is >= 2 in
usb_parse_configuration(), so find_iad() might do out-of-bounds access
to intf_assoc->bInterfaceCount.

And he's right, we don't check for crazy descriptors of this type very well, so
resolve this problem.  Yet another issue found by syzkaller...

Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit bd7a3fe770ebd8391d1c7d072ff88e9e76d063eb)

Orabug: 27207211
CVE: CVE-2017-16531

Signed-off-by: Tim Tianyang Chen <tianyang.chen@oracle.com>
Reviewed-by: Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
drivers/usb/core/config.c
include/uapi/linux/usb/ch9.h