]> www.infradead.org Git - users/hch/misc.git/commit
net: netconsole: fix wrong warning
authorBreno Leitao <leitao@debian.org>
Tue, 8 Oct 2024 09:43:24 +0000 (02:43 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Oct 2024 02:42:43 +0000 (19:42 -0700)
commitd94785bb46b6167382b1de3290eccc91fa98df53
tree44cc9992418b850c0704e01221a8f0d27296d735
parent8c924369cb56c3054dca504c2c9c3eb208272865
net: netconsole: fix wrong warning

A warning is triggered when there is insufficient space in the buffer
for userdata. However, this is not an issue since userdata will be sent
in the next iteration.

Current warning message:

    ------------[ cut here ]------------
     WARNING: CPU: 13 PID: 3013042 at drivers/net/netconsole.c:1122 write_ext_msg+0x3b6/0x3d0
      ? write_ext_msg+0x3b6/0x3d0
      console_flush_all+0x1e9/0x330

The code incorrectly issues a warning when this_chunk is zero, which is
a valid scenario. The warning should only be triggered when this_chunk
is negative.

Fixes: 1ec9daf95093 ("net: netconsole: append userdata to fragmented netconsole messages")
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241008094325.896208-1-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/netconsole.c