]> www.infradead.org Git - users/dwmw2/linux.git/commit
arm64: dts: qcom: msm8939: revert use of APCS mbox for RPM
authorFabien Parent <fabien.parent@linaro.org>
Wed, 4 Sep 2024 18:26:55 +0000 (11:26 -0700)
committerBjorn Andersson <andersson@kernel.org>
Wed, 4 Sep 2024 20:36:17 +0000 (15:36 -0500)
commitd92e9ea2f0f918d7b01cbacb838288bffccc8954
treec5d9919ecdbf8c072bdfd9e961d1e175a8b2fc8b
parentdfbe93f32c12f5628bd83303e10ba63621c259ae
arm64: dts: qcom: msm8939: revert use of APCS mbox for RPM

Commit 22e4e43484c4 ("arm64: dts: qcom: msm8939: Use mboxes
properties for APCS") broke the boot on msm8939 platforms.

The issue comes from the SMD driver failing to request the mbox
channel because of circular dependencies:
1. rpm -> apcs1_mbox -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm.
2. rpm -> apcs1_mbox -> gcc -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm
3. rpm -> apcs1_mbox -> apcs2 -> gcc -> rpmcc (RPM_SMD_XO_CLK_SRC) -> rpm

To fix this issue let's switch back to using the deprecated
qcom,ipc property for the RPM node.

Fixes: 22e4e43484c4 ("arm64: dts: qcom: msm8939: Use mboxes properties for APCS")
Signed-off-by: Fabien Parent <fabien.parent@linaro.org>
Link: https://lore.kernel.org/r/20240904-msm8939-rpm-apcs-fix-v1-1-b608e7e48fe1@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/msm8939.dtsi