]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: target: Fix NULL pointer dereference in core_scsi3_decode_spec_i_port()
authorMaurizio Lombardi <mlombard@redhat.com>
Thu, 12 Jun 2025 10:15:56 +0000 (12:15 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 16 Jun 2025 18:35:57 +0000 (14:35 -0400)
commitd8ab68bdb294b09a761e967dad374f2965e1913f
tree7e96140de9987c0c4719e25e993918bb7a33b719
parent5c3ba81923e02adae354ec8afd006f93289b4a3c
scsi: target: Fix NULL pointer dereference in core_scsi3_decode_spec_i_port()

The function core_scsi3_decode_spec_i_port(), in its error code path,
unconditionally calls core_scsi3_lunacl_undepend_item() passing the
dest_se_deve pointer, which may be NULL.

This can lead to a NULL pointer dereference if dest_se_deve remains
unset.

SPC-3 PR SPEC_I_PT: Unable to locate dest_tpg
Unable to handle kernel paging request at virtual address dfff800000000012
Call trace:
  core_scsi3_lunacl_undepend_item+0x2c/0xf0 [target_core_mod] (P)
  core_scsi3_decode_spec_i_port+0x120c/0x1c30 [target_core_mod]
  core_scsi3_emulate_pro_register+0x6b8/0xcd8 [target_core_mod]
  target_scsi3_emulate_pr_out+0x56c/0x840 [target_core_mod]

Fix this by adding a NULL check before calling
core_scsi3_lunacl_undepend_item()

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Link: https://lore.kernel.org/r/20250612101556.24829-1-mlombard@redhat.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Reviewed-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_pr.c