]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/amdkfd: fix loop error handling
authorTom Rix <trix@redhat.com>
Thu, 10 Feb 2022 17:04:18 +0000 (09:04 -0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 11 Feb 2022 21:11:33 +0000 (16:11 -0500)
commitd8a25e48585773afc573e835a52f9cbf409215bc
treea3ccb358c2daeb006fd5af6196c2f63646c765db
parentfd22013a098baca78679656d55f8fd0becb99a8d
drm/amdkfd: fix loop error handling

Clang static analysis reports this problem
kfd_chardev.c:2594:16: warning: The expression is an uninitialized value.
  The computed value will also be garbage
        while (ret && i--) {
                      ^~~

i is a loop variable and this block unwinds a problem in the loop.
When the error happens before the loop, this value is garbage.
Move the initialization of i to its decalaration.

Fixes: be072b06c739 ("drm/amdkfd: CRIU export BOs as prime dmabuf objects")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c