]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: hi556: Improve error logging when fwnode is not found
authorHans de Goede <hdegoede@redhat.com>
Thu, 19 Dec 2024 19:27:32 +0000 (20:27 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Sat, 15 Feb 2025 14:22:37 +0000 (15:22 +0100)
commitd8460548104de5cf8734afb6970477bf005e5765
treec72883cda2371332ffdcfbc8cef15d6a5e54d2de
parentddf3e6e028badb87606e34e308fbc597233126f2
media: hi556: Improve error logging when fwnode is not found

The hi556 driver waits for the endpoint fwnode to show up in case this
fwnode is created by a bridge-driver.

It does this by returning -EPROBE_DEFER, but it does not use
dev_err_probe() so no reason for deferring gets registered.

After 30 seconds the kernel logs a warning that the probe is still
deferred, which looks like this:

[   33.952052] i2c i2c-INT3537:00: deferred probe pending: (reason unknown)

Use dev_err_probe() when returning -EPROBE_DEFER to register the probe
deferral reason changing the error to:

deferred probe pending: waiting for fwnode graph endpoint

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/hi556.c