]> www.infradead.org Git - users/jedix/linux-maple.git/commit
locking/lockdep: Avoid creating new name string literals in lockdep_set_subclass()
authorAhmed Ehab <bottaawesome633@gmail.com>
Sat, 24 Aug 2024 22:10:30 +0000 (01:10 +0300)
committerBoqun Feng <boqun.feng@gmail.com>
Fri, 18 Oct 2024 03:07:23 +0000 (20:07 -0700)
commitd7fe143cb115076fed0126ad8cf5ba6c3e575e43
tree0d410064425a157c21079e06b2b6507dab7fdb65
parent0784181b44af831a3fa52e1e5ff77c388d699dba
locking/lockdep: Avoid creating new name string literals in lockdep_set_subclass()

Syzbot reports a problem that a warning will be triggered while
searching a lock class in look_up_lock_class().

The cause of the issue is that a new name is created and used by
lockdep_set_subclass() instead of using the existing one. This results
in a lock instance has a different name pointer than previous registered
one stored in lock class, and WARN_ONCE() is triggered because of that
in look_up_lock_class().

To fix this, change lockdep_set_subclass() to use the existing name
instead of a new one. Hence, no new name will be created by
lockdep_set_subclass(). Hence, the warning is avoided.

[boqun: Reword the commit log to state the correct issue]

Reported-by: <syzbot+7f4a6f7f7051474e40ad@syzkaller.appspotmail.com>
Fixes: de8f5e4f2dc1f ("lockdep: Introduce wait-type checks")
Cc: stable@vger.kernel.org
Signed-off-by: Ahmed Ehab <bottaawesome633@gmail.com>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/lkml/20240824221031.7751-1-bottaawesome633@gmail.com/
include/linux/lockdep.h