]> www.infradead.org Git - users/jedix/linux-maple.git/commit
NFSD: nfsd_unlink() clobbers non-zero status returned from fh_fill_pre_attrs()
authorChuck Lever <chuck.lever@oracle.com>
Sun, 26 Jan 2025 21:50:17 +0000 (16:50 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 10 Mar 2025 13:10:56 +0000 (09:10 -0400)
commitd7d8e3169b56e7696559a2427c922c0d55debcec
treef1d6b146fc9331d4340a3f0bfb6aa7bf993b69d7
parent904201c7b5f1bb15fe0cb978ec3e40c647100600
NFSD: nfsd_unlink() clobbers non-zero status returned from fh_fill_pre_attrs()

If fh_fill_pre_attrs() returns a non-zero status, the error flow
takes it through out_unlock, which then overwrites the returned
status code with

err = nfserrno(host_err);

Fixes: a332018a91c4 ("nfsd: handle failure to collect pre/post-op attrs more sanely")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/vfs.c