]> www.infradead.org Git - users/dwmw2/linux.git/commit
Revert "SUNRPC: Use RMW bitops in single-threaded hot paths"
authorChuck Lever <chuck.lever@oracle.com>
Fri, 6 Jan 2023 17:43:37 +0000 (12:43 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:19:25 +0000 (16:19 +0200)
commitd7cfba56fa75f06ca57afa469e44d4dbc284acbb
tree8c653d038f4b28c3d80c1bab3e7d849a7232c816
parent0b778361998d6c6356b8d2fc7ddf025fb3224654
Revert "SUNRPC: Use RMW bitops in single-threaded hot paths"

[ Upstream commit 7827c81f0248e3c2f40d438b020f3d222f002171 ]

The premise that "Once an svc thread is scheduled and executing an
RPC, no other processes will touch svc_rqst::rq_flags" is false.
svc_xprt_enqueue() examines the RQ_BUSY flag in scheduled nfsd
threads when determining which thread to wake up next.

Found via KCSAN.

Fixes: 28df0988815f ("SUNRPC: Use RMW bitops in single-threaded hot paths")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4proc.c
fs/nfsd/nfs4xdr.c
net/sunrpc/auth_gss/svcauth_gss.c
net/sunrpc/svc.c
net/sunrpc/svc_xprt.c
net/sunrpc/svcsock.c
net/sunrpc/xprtrdma/svc_rdma_transport.c