]> www.infradead.org Git - users/jedix/linux-maple.git/commit
phy: qcom-qmp-ufs: check for mode type for phy setting
authorNitin Rawat <quic_nitirawa@quicinc.com>
Mon, 7 Apr 2025 12:10:08 +0000 (17:40 +0530)
committerVinod Koul <vkoul@kernel.org>
Fri, 11 Apr 2025 07:12:26 +0000 (12:42 +0530)
commitd784552e76a23c4ffad0e383670cd1d86064a6be
tree442fc16f662d12e1ecaeb2f85fe744c9d94018bc
parentb47158fb42959c417ff2662075c0d46fb783d5d1
phy: qcom-qmp-ufs: check for mode type for phy setting

Generally all target supports Rate B but for very few like SM8550,
two sets of UFS PHY settings are provided, one set is to support
HS-G5 Rate A and another set is to support HS-G4 and lower
gears with Rate B.

Commit b02cc9a17679("phy: qcom-qmp-ufs: Add PHY Configuration support
for sm8750") apply Rate B setting for SM8550 gear 5 without checking
for mode value (Rate A or Rate B) from Controller driver which caused
issue as SM8550 support rate A for Gear 5.

Fix this by adding mode check before applying Rat B phy setting.

Fixes: b02cc9a17679 ("phy: qcom-qmp-ufs: Add PHY Configuration support for sm8750")
Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
Closes: https://lore.kernel.org/all/430ed11c-0490-45be-897b-27cad9682371@quicinc.com/
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
Link: https://lore.kernel.org/r/20250407121008.22230-1-quic_nitirawa@quicinc.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c