]> www.infradead.org Git - users/hch/misc.git/commit
net: pcs: xpcs: actively unset DW_VR_MII_DIG_CTRL1_2G5_EN for 1G SGMII
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 14 Jan 2025 16:47:21 +0000 (18:47 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 15 Jan 2025 21:22:23 +0000 (13:22 -0800)
commitd6e3316a1680305da291a5b5deaf424559aaf06c
tree94867f1bc32e9d9a002e270391934d1f6cca6b80
parent5c71729ab92c7e710d48ed93043a2d1e35cc8d3c
net: pcs: xpcs: actively unset DW_VR_MII_DIG_CTRL1_2G5_EN for 1G SGMII

xpcs_config_2500basex() sets DW_VR_MII_DIG_CTRL1_2G5_EN, but
xpcs_config_aneg_c37_sgmii() never unsets it. So, on a protocol change
from 2500base-x to sgmii, the DW_VR_MII_DIG_CTRL1_2G5_EN bit will remain
set.

Fixes: f27abde3042a ("net: pcs: add 2500BASEX support for Intel mGbE controller")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/20250114164721.2879380-2-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/pcs-xpcs.c